Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Support disableStaticImages setting #23167

Merged

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jun 21, 2023

Closes #22899

What I did

Support disableStaticImages setting in Next.js-based Storybooks.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic self-assigned this Jun 21, 2023
@valentinpalkovic valentinpalkovic added bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 21, 2023
@valentinpalkovic valentinpalkovic changed the title Support disableStaticImages setting in Nextjs Next.js: Support disableStaticImages setting Jun 21, 2023
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@valentinpalkovic valentinpalkovic added the ci:daily Run the CI jobs that normally run in the daily job. label Jun 21, 2023
@ssijak
Copy link

ssijak commented Jun 26, 2023

Very much interested in this. What is the expected timeline for this being available on npm?

@KseniaAK
Copy link

Hi! Thank you for working on this fix! My team is also very interested in this work as it's a blocker for our app's upgrade to storybook v7. Seconding the above question - what is the timeline for its release?

@valentinpalkovic valentinpalkovic merged commit eda9fc2 into next Jun 27, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/support-disable-static-images-prop-in-nextjs branch June 27, 2023 23:11
@valentinpalkovic
Copy link
Contributor Author

valentinpalkovic commented Jun 27, 2023

Hi @ssijak, @KseniaAK

Hopefully the next few days we can release this feature with a next 7.1 beta release!

JReinhold pushed a commit that referenced this pull request Jul 2, 2023
…tatic-images-prop-in-nextjs

Next.js: Support disableStaticImages setting

(cherry picked from commit eda9fc2)
@github-actions github-actions bot mentioned this pull request Jul 2, 2023
15 tasks
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job. patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: @storybook/nextjs does not respect disableStaticImages flag in next.config.js
4 participants