Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix story hoisting snippets #23239

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Docs: Fix story hoisting snippets #23239

merged 2 commits into from
Jun 30, 2023

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Jun 27, 2023 •
edited
Loading

Related discussion: #22529 (comment)

What I did

See title

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kylegach kylegach added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 27, 2023
@kylegach kylegach self-assigned this Jun 27, 2023
@kylegach kylegach changed the title Fix story hoisting snippets Docs: Fix story hoisting snippets Jun 28, 2023
@kylegach kylegach force-pushed the fix-story-hoisting-snippets branch from d957065 to 620fa19 Compare June 28, 2023 14:27
@kylegach kylegach force-pushed the fix-story-hoisting-snippets branch from 620fa19 to 895686c Compare June 28, 2023 16:46
jonniebigodes
jonniebigodes approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my end @kylegach, going to merge this one once the checklist clears

@jonniebigodes jonniebigodes merged commit 399321b into next Jun 30, 2023
@jonniebigodes jonniebigodes deleted the fix-story-hoisting-snippets branch June 30, 2023 13:56
@github-actions github-actions bot mentioned this pull request Jun 30, 2023
Merged
6 tasks
JReinhold pushed a commit that referenced this pull request Jul 2, 2023
@jonniebigodes @github-actions
Merge pull request #23239 from storybookjs/fix-story-hoisting-snippets
8846456 
Docs: Fix story hoisting snippets
(cherry picked from commit 399321b)
@github-actions github-actions bot mentioned this pull request Jul 2, 2023
Merged
15 tasks
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 3, 2023
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonniebigodes jonniebigodes jonniebigodes approved these changes

Assignees

@kylegach kylegach

Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylegach @jonniebigodes