Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF-Tools: Remove prettier from printConfig #23766

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Aug 9, 2023

Should fix #23748

What I did

Remove prettier dep from csf-tools to fix perf regression

How to test

Ask MIchael for perf insights :)

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@kasperpeulen kasperpeulen added bug ci:normal patch:yes Bugfix & documentation PR that need to be picked to main branch labels Aug 9, 2023
Comment on lines -732 to -735
pretty = prettier.format(result.code, {
...prettierConfig,
filepath: config.fileName ?? 'main.ts',
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasperpeulen can we detect the existence of node_modules/.bin/prettier and call it with the right arguments if it exists in a child_process?

That way we get the best of both worlds!?

@shilman
Copy link
Member

shilman commented Aug 9, 2023

@kasperpeulen regression fixed (top row, pink column). great job!

image

@kasperpeulen kasperpeulen merged commit 8ee6798 into next Aug 9, 2023
20 of 28 checks passed
@kasperpeulen kasperpeulen deleted the kasper/remove-prettier-from-csf-tools branch August 9, 2023 09:16
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
…m-csf-tools

CSF-Tools: Remove prettier from printConfig
(cherry picked from commit 8ee6798)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
…m-csf-tools

CSF-Tools: Remove prettier from printConfig
(cherry picked from commit 8ee6798)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
…m-csf-tools

CSF-Tools: Remove prettier from printConfig
(cherry picked from commit 8ee6798)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
…m-csf-tools

CSF-Tools: Remove prettier from printConfig
(cherry picked from commit 8ee6798)
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
4 tasks
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: UI performance regression
3 participants