Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons: Fix key is not a prop warning #23935

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Addons: Fix key is not a prop warning #23935

merged 1 commit into from
Aug 24, 2023

Conversation

kasperpeulen
Copy link
Contributor

Closes #23903

What I did

Removed the deprecated key also in the docs

How to test

See #23903 for how to reproduce, and check the bug doesn't appear.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@kasperpeulen kasperpeulen merged commit 0d1960e into next Aug 24, 2023
15 checks passed
@kasperpeulen kasperpeulen deleted the kasper/23903 branch August 24, 2023 08:57
@github-actions github-actions bot mentioned this pull request Aug 24, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Warning: Unknown: key is not a prop
2 participants