Build: Migrate @storybook/manager-api to strict TS

[subhajit20]

Closes #22176

What I did

Migrate @storybook/manager-api to strict-ts

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

[yannbf]

Hey @subhajit20 thank you so much for your contribution! @kasperpeulen would you mind reviewing? Thanks.

[subhajit20]

Hey @subhajit20 thank you so much for your contribution! @kasperpeulen would you mind reviewing? Thanks.

Hey in my case @ts-ignore is not working, could I use @ts-nocheck instead ?

[kasperpeulen]

Converting this to draft, as there are still type errors.

Hey in my case @ts-ignore is not working, could I use @ts-nocheck instead ?
You can use @ts-expect-error but preferably, the real problem should be solved :)

[yannbf]

For some reason node_modules got in. This should not be part of the PR. Can you remove it?

[yannbf]

Thank you so much for your contribution @subhajit20! Unfortunately, adding any, ? and ! operators on the code won't result in the best outcome we can have. We need to think over and rework the code if needed, or add new code paths (e.g. throw an error if some value is expected but is not there). I can imagine you might not have the context necessary for this, so I'd like to request @ndelangen and @kasperpeulen to take a look into this PR in more detail, whenever you can.

Thank you!