Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add the new structure for the mobile layout #24227

Merged
merged 17 commits into from
Sep 19, 2023
Merged

Conversation

cdedreuille
Copy link
Contributor

Closes #24213

What I did

This PR is based on all the work done here #20412. In this PR we are focusing on creating the base layout for mobile and allocating a spot on mobile for the main navigation. The content of this new section will be created in following PRs. Here's a list of the work done here:

  • Update useMediaQuery (initially created by @valentinpalkovic) to use window.matchMedia instead
  • Hide sidebar and addon panel on Mobile
  • Adjust the layout and preview sizing to work on mobile
  • Add the core structure for the mobile navigation

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

To test it locally, open Storybook UI library from the monorepo with yarn storybook:ui and test that you can see all stories correctly on mobile. You should also see an empty bar at the bottom for the future mobile navigation.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@github-actions
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","build","dependencies"]

🚫

PR is not labeled with one of: ["ci:normal","ci:merged","ci:daily","ci:docs"]

Generated by 🚫 dangerJS against f21d349

@cdedreuille cdedreuille added maintenance User-facing maintenance tasks ci:normal labels Sep 19, 2023
@cdedreuille cdedreuille self-assigned this Sep 19, 2023
@yannbf yannbf added the ui label Sep 19, 2023
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! only a few very minor change suggestions

code/ui/manager/src/components/layout/Layout.stories.tsx Outdated Show resolved Hide resolved
code/ui/manager/src/components/layout/Layout.tsx Outdated Show resolved Hide resolved
code/ui/manager/src/components/layout/Layout.tsx Outdated Show resolved Hide resolved
code/ui/manager/src/components/layout/Layout.tsx Outdated Show resolved Hide resolved
code/ui/manager/src/constants.ts Outdated Show resolved Hide resolved
Base automatically changed from norbert/panel-size to new-layout September 19, 2023 12:10
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@cdedreuille cdedreuille merged commit 385a406 into new-layout Sep 19, 2023
44 of 45 checks passed
@cdedreuille cdedreuille deleted the charles-mobile-1 branch September 19, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Layout to be responsive instead of desktop & mobile being separate
3 participants