Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Create help.yml #24704

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Build: Create help.yml #24704

merged 4 commits into from
Nov 15, 2023

Conversation

joevaugh4n
Copy link
Contributor

@joevaugh4n joevaugh4n commented Nov 3, 2023

What I did

Add a template for help requests to the repo.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

N/A

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only. labels Nov 3, 2023
@ndelangen ndelangen self-assigned this Nov 3, 2023
@ndelangen ndelangen changed the title Create help.yml Build: Create help.yml Nov 3, 2023
Copy link
Contributor

@vanessayuenn vanessayuenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you also change the "new issue" configuration to include a callout to this though?

@joevaugh4n
Copy link
Contributor Author

ty @vanessayuenn! Like these prompts? Sure can

CleanShot 2023-11-03 at 15 33 51@2x

@joevaugh4n
Copy link
Contributor Author

thank you @kylegach ! is this ready to merge now, folks?

@joevaugh4n
Copy link
Contributor Author

Hi all - does anything else need to happen to merge this?

@kylegach kylegach self-requested a review November 15, 2023 18:50
Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@joevaugh4n
Copy link
Contributor Author

Updated to change the config template too. This should now resolve @vanessayuenn's request! Lmk if I need to change anything further?

Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@kylegach kylegach merged commit 4c13b24 into next Nov 15, 2023
18 checks passed
@kylegach kylegach deleted the joevaugh4n-patch-3 branch November 15, 2023 19:09
@github-actions github-actions bot mentioned this pull request Nov 15, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants