Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Model loaders as before each and restore mocks properly #24948

Merged
merged 12 commits into from
Nov 22, 2023

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Nov 22, 2023

What I did

Model loaders as before each and restore mocks properly

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  • Add console.log in preview, meta and story loaders. And check that they are run in that order, even if you gonna await something before it.
  • Setup a spyOn in a play function, and see that the mock is reset when you are switching to a new story.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-24948-sha-12960c76. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-24948-sha-12960c76
Triggered by @kasperpeulen
Repository storybookjs/storybook
Branch kasper/model-loaders-as-before-each
Commit 12960c76
Datetime Wed Nov 22 16:24:00 UTC 2023 (1700670240)
Workflow run 6960070947

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=24948

Copy link

socket-security bot commented Nov 22, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job pulling this together @kasperpeulen. What's the release plan with @storybook/csf?

code/lib/test/src/index.ts Outdated Show resolved Hide resolved
code/lib/preview-api/src/modules/store/csf/prepareStory.ts Outdated Show resolved Hide resolved
code/lib/test/src/index.ts Outdated Show resolved Hide resolved
@kasperpeulen
Copy link
Contributor Author

Great job pulling this together @kasperpeulen. What's the release plan with @storybook/csf?

When I have CI green, and did some more QA, I think I will release csf to stable.

@kasperpeulen kasperpeulen force-pushed the kasper/model-loaders-as-before-each branch from 11dce16 to 12960c7 Compare November 22, 2023 16:13
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! 💯

@kasperpeulen kasperpeulen merged commit c9afa39 into next Nov 22, 2023
60 of 61 checks passed
@kasperpeulen kasperpeulen deleted the kasper/model-loaders-as-before-each branch November 22, 2023 16:59
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants