Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next.js: Fix E2E tests failing to navigate to story #24950

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Next.js: Fix E2E tests failing to navigate to story #24950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions code/e2e-tests/framework-nextjs.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ test.describe('Next.js', () => {

// TODO: Test is flaky, investigate why
test.skip('should lazy load images by default', async () => {
await sbPage.navigateToStory('frameworks/nextjs/Image', 'lazy');
await sbPage.navigateToStory('stories/frameworks/nextjs/Image', 'lazy');

const img = sbPage.previewRoot().locator('img');

Expand All @@ -39,7 +39,7 @@ test.describe('Next.js', () => {

// TODO: Test is flaky, investigate why
test.skip('should eager load images when loading parameter is set to eager', async () => {
await sbPage.navigateToStory('frameworks/nextjs/Image', 'eager');
await sbPage.navigateToStory('stories/frameworks/nextjs/Image', 'eager');

const img = sbPage.previewRoot().locator('img');

Expand Down Expand Up @@ -67,7 +67,10 @@ test.describe('Next.js', () => {
test.beforeEach(async ({ page }) => {
sbPage = new SbPage(page);

await sbPage.navigateToStory('frameworks/nextjs-nextjs-default-js/Navigation', 'default');
await sbPage.navigateToStory(
'stories/frameworks/nextjs-nextjs-default-js/Navigation',
'default'
);
root = sbPage.previewRoot();
});

Expand Down Expand Up @@ -99,7 +102,7 @@ test.describe('Next.js', () => {
test.beforeEach(async ({ page }) => {
sbPage = new SbPage(page);

await sbPage.navigateToStory('frameworks/nextjs-nextjs-default-js/Router', 'default');
await sbPage.navigateToStory('stories/frameworks/nextjs-nextjs-default-js/Router', 'default');
root = sbPage.previewRoot();
});

Expand Down
Loading