Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack5: Resolve circular dependency and fix HMR #24974

Merged

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Nov 24, 2023

Closes N/A

What I did

Moved the helper method to get a list of virtual modes to @storybook/builder-webpack to resolve a circular dependency. Furthermore, HMR was fixed when the lazyCompilation builder option for Webpack5 was set.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run a Webpack5-based sandbox
  2. Set builder: { lazyCompilation: true }
  3. Check whether HMR is working

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic requested review from JReinhold and removed request for kasperpeulen, yannbf and ndelangen November 24, 2023 12:55
@valentinpalkovic valentinpalkovic self-assigned this Nov 24, 2023
@valentinpalkovic valentinpalkovic added bug builder-webpack5 ci:daily Run the CI jobs that normally run in the daily job. labels Nov 24, 2023
@valentinpalkovic valentinpalkovic force-pushed the valentin/move-virtual-module-calc-to-builder-webpack5 branch from 5846650 to 8e4e5c5 Compare November 24, 2023 12:59
@valentinpalkovic valentinpalkovic merged commit 1cb73d3 into next Nov 24, 2023
107 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/move-virtual-module-calc-to-builder-webpack5 branch November 24, 2023 13:40
@github-actions github-actions bot mentioned this pull request Nov 24, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug builder-webpack5 ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants