Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Fix next/font/local usage in babel mode #25045

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Nov 29, 2023

Closes #25044

What I did

Fixes next/font/local usage in Babel mode for Next.js

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run a Next.js sandbox
  2. Setup a local font as described here
  3. Check whether local font works

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-25045-sha-cc9ccee0. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-25045-sha-cc9ccee0
Triggered by @valentinpalkovic
Repository storybookjs/storybook
Branch valentin/nextjs-fix-local-font-issue
Commit cc9ccee0
Datetime Wed Nov 29 19:54:42 UTC 2023 (1701287682)
Workflow run 7037799834

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25045

@valentinpalkovic valentinpalkovic self-assigned this Nov 29, 2023
@valentinpalkovic valentinpalkovic added patch:yes Bugfix & documentation PR that need to be picked to main branch nextjs ci:normal upgrade:7.6 bug labels Nov 29, 2023
@valentinpalkovic valentinpalkovic merged commit aebcbee into next Nov 29, 2023
65 of 76 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/nextjs-fix-local-font-issue branch November 29, 2023 22:07
@github-actions github-actions bot mentioned this pull request Nov 29, 2023
36 tasks
storybook-bot pushed a commit that referenced this pull request Nov 30, 2023
…font-issue

Next.js: Fix next/font/local usage in babel mode

(cherry picked from commit aebcbee)
@github-actions github-actions bot mentioned this pull request Nov 30, 2023
8 tasks
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 1, 2023
@github-actions github-actions bot mentioned this pull request Dec 7, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal nextjs patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch upgrade:7.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: next/font/local fails to properly set paths in Storybook v7.6
1 participant