-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NextJS: Add experimental RSC support #25091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
feature request
react
nextjs
ci:merged
Run the CI jobs that normally run when merged.
labels
Dec 3, 2023
kasperpeulen
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
shilman
requested review from
ndelangen,
yannbf and
valentinpalkovic
as code owners
December 4, 2023 17:21
shilman
commented
Dec 5, 2023
This was referenced Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21540
What I did
Turns out that in NextJS's version of React, it's possible to render async components in the client using React Suspense.
To make this ergonomic for NextJS users, I:
experimentalNextRSC
to add RSC supportnextjs.rsc
to selectively disable RSC on stories/componentsChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Run the NextJS sandbox and view the sample stories. Observe that both the basic & nested stories work, and that the intentionally erroring stories error in reasonable ways.
Documentation
MIGRATION.MD
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>