Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Remove deprecated WithTooltip props #25440

Merged
merged 7 commits into from
Jan 4, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jan 3, 2024

Closes #25332

What I did

This PR does the following:

  • The deprecated properties tooltipShown, closeOnClick, and onVisibilityChange of WithTooltipComponent from @storybook/components are now removed.
  • replaces the deprecated prop from Addon-themes
  • Adds tests to some Tooltip stories to test its functionality

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Fails
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against d3f2e43

Copy link
Contributor

@ShaunEvening ShaunEvening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Are there any docs that we need to change / remove too?

@yannbf yannbf force-pushed the yann/remove-deprecated-with-tooltip-props branch from 60552e6 to caf1644 Compare January 4, 2024 17:09
@yannbf
Copy link
Member Author

yannbf commented Jan 4, 2024

Looks good! Are there any docs that we need to change / remove too?

Not really, I don't think the components are documented apart from the source of their stories

@yannbf yannbf merged commit cca26e9 into next Jan 4, 2024
54 of 57 checks passed
@yannbf yannbf deleted the yann/remove-deprecated-with-tooltip-props branch January 4, 2024 20:10
@github-actions github-actions bot mentioned this pull request Jan 4, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecations in the WithTooltip component
2 participants