React: Refactor RSC out of Next #25591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
force-pushed
the
shilman/refactor-client-rsc
branch
from
2e87a47
to
6452ff8
Compare
shilman
force-pushed
the
shilman/refactor-client-rsc
branch
from
dc69d91
to
4ac8515
Compare
shilman
added
BREAKING CHANGE
and removed
maintenance
shilman
requested review from
valentinpalkovic,
kasperpeulen,
ndelangen and
yannbf
as code owners
shilman
force-pushed
the
shilman/refactor-client-rsc
branch
from
4ac8515
to
8c9c081
Compare
shilman
force-pushed
the
shilman/refactor-client-rsc
branch
from
8c9c081
to
4f183a9
Compare
21 tasks
kylegach
added a commit
that referenced
this pull request
Jan 17, 2024
- Per #25591 - `features.experimentalNextRSC` -> `features.experimentalRSC` - `parameters.nextjs.rsc` -> `parameters.react.rsc`
tmeasday
reviewed
Jan 17, 2024
| @@ -170,7 +167,7 @@ export const webpackFinal: StorybookConfig['webpackFinal'] = async (baseConfig, | |||
| configureFastRefresh(baseConfig); | |||
| } | |||
|
|
|||
| if (options.features?.experimentalNextRSC) { | |||
| if (options.features?.experimentalRSC) { | |||
There was a problem hiding this comment.
Should this still be in this file?
There was a problem hiding this comment.
It controls a webpack configuration. Where would you imagine it living?
kylegach
added a commit
that referenced
this pull request
Jan 18, 2024
- Per #25591 - `features.experimentalNextRSC` -> `features.experimentalRSC` - `parameters.nextjs.rsc` -> `parameters.react.rsc`
kylegach
added a commit
that referenced
this pull request
Jan 24, 2024
- Per #25591 - `features.experimentalNextRSC` -> `features.experimentalRSC` - `parameters.nextjs.rsc` -> `parameters.react.rsc`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
The RSC approach introduced in 7.6 can apply to any React project that uses an appropriate 18.3 canary.
So this breaking change changes the feature flag & configuration parameter so that it's no longer NextJS specific.
experimentalNextRSC=>experimentalRSCnextjs.rsc=>react.rscThere is an appropriate note in
MIGRATION.md. And since we don't actually support any other usage yet, we have not documented its use with any other framework yet.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
🦋 Canary release
This pull request has been released as version
0.0.0-pr-25591-sha-337ab526. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-25591-sha-337ab526shilman/refactor-client-rsc337ab5261705158372)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25591