Vite: Add a rollup-plugin-webpack-stats to allow stats from preview builds
#25923
Conversation
| @@ -28,5 +35,18 @@ export async function build(options: Options) { | |||
| }).build; | |||
|
|
|||
| const finalConfig = await presets.apply('viteFinal', config, options); | |||
|
|
|||
| const turbosnapPlugin = findPlugin(finalConfig, 'rollup-plugin-turbosnap'); | |||
| if (turbosnapPlugin) { | |||
There was a problem hiding this comment.
I'm not sure if we should maybe not do this is --webpack-stats-json isn't passed. That would be inconsistent, and maybe confusing.
But it changes the behaviour if we drop the plugin if you don't pass the flag (that still wrote the stats file previously).
tmeasday
changed the title
rollup-plugin-webpack-stats to allow stats from preview buildsrollup-plugin-webpack-stats to allow stats from preview builds
|
Right you are @JReinhold |
|
|
||
| const turbosnapPluginName = 'rollup-plugin-turbosnap'; | ||
| const hasTurbosnapPlugin = | ||
| finalConfig.plugins && hasVitePlugins(finalConfig.plugins, [turbosnapPluginName]); |
There was a problem hiding this comment.
It seems that this code is causing a behavior that always displays a warning.
| finalConfig.plugins && hasVitePlugins(finalConfig.plugins, [turbosnapPluginName]); | |
| finalConfig.plugins && await hasVitePlugins(finalConfig.plugins, [turbosnapPluginName]); |
There was a problem hiding this comment.
Hi @acid-chicken -- that makes sense! But how to reproduce? I'm not seeing the problem on a basic react-vite 8.0.0-beta.2 sandbox project. Any tips?
There was a problem hiding this comment.
@tmeasday Thank you for the reply!
Digging a little deeper into this issue, I found that this log only appears at build time.
Therefore, you can probably reproduce by executing yarn create vite (w/ react & typescript option), yarn dlx storybook@next init, then yarn build-storybook (not yarn storybook).
I hope this will be of some help.
There was a problem hiding this comment.
Ahh, OK of course. Thank you @acid-chicken
What I did
Integrated https://github.com/IanVS/vite-plugin-turbosnap (thanks @IanVS) so that the
--webpack-stats-jsonflag works for Vite builds also.One limitation is that it only works in build/production mode, as it is a rollup plugin. However AFAIK the only user of this flag is Chromatic and it only cares about built storybooks.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>