Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1736) Expose forceReRender over channel [WIP] #2600

Closed
wants to merge 2 commits into from

Conversation

dangreenisrael
Copy link
Member

@dangreenisrael dangreenisrael commented Dec 28, 2017

Issue: #1736

This is not currently working

What I did

Allowed force render to be called via addonAPI.forceReRender

ToDo:

  • Manually test
  • Automated tests
  • Update current docs site
  • Update new docs site

How to test

Is this testable with jest or storyshots?

Does this need a new example in the kitchen sink apps?

  • possibly

Does this need an update to the documentation?

  • Yes, for addons api

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Dec 28, 2017

Codecov Report

Merging #2600 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2600      +/-   ##
==========================================
- Coverage   32.61%   32.55%   -0.06%     
==========================================
  Files         397      397              
  Lines        8855     8871      +16     
  Branches      964      953      -11     
==========================================
  Hits         2888     2888              
- Misses       5275     5317      +42     
+ Partials      692      666      -26
Impacted Files Coverage Δ
app/react/src/client/preview/index.js 0% <0%> (ø) ⬆️
app/angular/src/client/preview/index.js 0% <0%> (ø) ⬆️
app/vue/src/client/preview/index.js 0% <0%> (ø) ⬆️
lib/addons/src/index.js 0% <0%> (ø) ⬆️
...modules/ui/components/stories_panel/text_filter.js 30.98% <0%> (ø) ⬆️
...tories_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 7.93% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 82.82% <0%> (ø) ⬆️
addons/graphql/src/components/FullScreen/index.js 0% <0%> (ø) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6239662...a4be990. Read the comment docs.

@dangreenisrael dangreenisrael changed the title (#1736) Expose forceReRender over channel (#1736) Expose forceReRender over channel [WIP] Dec 28, 2017
@dangreenisrael
Copy link
Member Author

dangreenisrael commented Dec 31, 2017

This is being closed due to a problem with accessing StoryStore on emitted events.

@Hypnosphi Hypnosphi deleted the (#1736)-Force-render-via-channel branch February 17, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant