Vite: Fix bug that meant we always warned about TS plugin #26051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I did the QA steps above already) |
tmeasday
changed the title
tmeasday
changed the title
shilman
approved these changes
Feb 16, 2024
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @acid-chicken! https://github.com/storybookjs/storybook/pull/25923/files#r1489101715
What I did
Fix broken check by awaiting promise
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
build-storybookon a vite sandbox, check there is no warning.