Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Upgrade esbuild (0.20.1) #26255

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Build: Upgrade esbuild (0.20.1) #26255

merged 4 commits into from
Mar 6, 2024

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Feb 29, 2024

This just upgrades esbuild to 0.20.1

Do you have any concerns with doing this?

The reason (other than staying up to date) is that many other peers are now on 0.20.x, so storybook's various packages are resulting in our dependency tree have many copies of esbuild instead of a single de-duped copy.

@@ -52,7 +52,7 @@
"@yarnpkg/esbuild-plugin-pnp": "^3.0.0-rc.10",
"browser-assert": "^1.2.1",
"ejs": "^3.1.8",
"esbuild": "^0.18.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valentinpalkovic do you remember why we are on 0.18? I reckon something happened in the past but I just don't remember

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly have no clue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the best way to prove everything is fine other than CI being happy?

if you can point me in the right direction, i can try do further testing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We upgraded it last 9 months ago.

Screenshot 2024-03-05 at 14 21 48

#21727

It might just have been a hiccup with mixed versions.

This LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm,.. maybe this:
#26112

@ndelangen ndelangen changed the title chore: upgrade esbuild to 0.20.1 Build: Upgrade esbuild (0.20.1) Mar 5, 2024
@ndelangen ndelangen merged commit 1fac5e1 into storybookjs:next Mar 6, 2024
45 of 46 checks passed
@github-actions github-actions bot mentioned this pull request Mar 6, 2024
13 tasks
@43081j 43081j deleted the esbuild branch March 6, 2024 14:37
@@ -52,7 +52,7 @@
"@yarnpkg/libzip": "2.3.0",
"chalk": "^4.1.0",
"cross-spawn": "^7.0.3",
"esbuild": "^0.18.0",
"esbuild": "^18.0.0 || ^19.0.0 || ^0.20.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

18.0.0 -> 0.18.0
19.0.0 -> 0.19.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a typo! 👀 this was added by @ndelangen i think, probably trying to account for mixed versions in dependency trees. should be easy enough to fix at least

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen already takes care of it: #26405
Thanks for letting us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot start service: Host version "0.18.20" does not match binary version "0.19.7"
5 participants