Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls: Fix type summary when table.type unset #26283

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 2, 2024

Closes: #25909

What I did

When the user specifies a type but there is no table.type annotation generated, display this correctly in the ArgRow components

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

See the Chromatic changes for the ArgRow stories

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch block: argstable labels Mar 2, 2024
@ndelangen
Copy link
Member

Does this fix: #25909 @shilman ?

@shilman
Copy link
Member Author

shilman commented Mar 2, 2024

@ndelangen I haven't tested the cases reported in that issue. It fixes the bug we looked at together yesterday, but that may or may not fix the bigger problem. I can take a closer look this weekend.

@ndelangen
Copy link
Member

OK, you might want to use both reproductions in the issue, they seem related, but are different.

I suspect the second one has a completely different cause.

@ndelangen ndelangen marked this pull request as draft March 2, 2024 08:48
@shilman
Copy link
Member Author

shilman commented Mar 3, 2024

@ndelangen I commented on the cause of the second issue. Self-merging this PR which fixes a bug, possibly not related to either of the issues in the linked issue.

@shilman shilman marked this pull request as ready for review March 3, 2024 12:57
@shilman shilman changed the title Controls: Fix type summary Controls: Fix type summary when table.type unset Mar 3, 2024
@shilman shilman merged commit f0beb18 into next Mar 3, 2024
66 of 74 checks passed
@shilman shilman deleted the shilman/fix-controls-type-summary branch March 3, 2024 12:58
@github-actions github-actions bot mentioned this pull request Mar 3, 2024
17 tasks
storybook-bot pushed a commit that referenced this pull request Mar 3, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
@github-actions github-actions bot mentioned this pull request Mar 3, 2024
8 tasks
storybook-bot pushed a commit that referenced this pull request Mar 4, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 4, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 4, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 4, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 4, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 4, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 4, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 4, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 5, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 5, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 10, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 11, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 11, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 11, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 11, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 11, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 11, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 12, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
@github-actions github-actions bot mentioned this pull request Mar 12, 2024
11 tasks
storybook-bot pushed a commit that referenced this pull request Mar 12, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 12, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 12, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 12, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 12, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 12, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 13, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 13, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 13, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 13, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 13, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 13, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 14, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 14, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 15, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 15, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 16, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 17, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 17, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
storybook-bot pushed a commit that referenced this pull request Mar 17, 2024
…summary

Controls: Fix type summary when table.type unset
(cherry picked from commit f0beb18)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: argstable bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook v8.0.0-alpha.16 unknown types
2 participants