Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport: Fix editing when default viewport is set #26360

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 7, 2024

Closes #26334

What I did

Fixed a reactivity bug that caused the viewport to snap back to the default viewport when the user tries to edit.

Checklist for Contributors

Testing

  1. Added a test for this case
  2. Checked that it fails with the old code
  3. Checked that it passes with the new

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

See E2E test

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

code/addons/viewport/src/Tool.tsx Outdated Show resolved Hide resolved
Copy link

nx-cloud bot commented Mar 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2550a3b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman merged commit 099def2 into next Mar 7, 2024
55 checks passed
@shilman shilman deleted the shilman/26334-fix-viewport-edit branch March 7, 2024 06:23
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Viewport cannot be changed
2 participants