Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update multiple components guidance #26544

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

kylegach
Copy link
Contributor

Closes #15954

What I did

Checklist for Contributors

Testing

Manual testing

  1. Follow the steps in the contributing instructions for this branch, update-docs-multiple-components

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@kylegach kylegach self-assigned this Mar 18, 2024
Copy link

nx-cloud bot commented Mar 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 43b4f0f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kylegach kylegach force-pushed the update-docs-multiple-components branch from afff61e to dba4179 Compare March 18, 2024 17:20
@kylegach kylegach force-pushed the update-docs-multiple-components branch from dba4179 to c5e8825 Compare March 26, 2024 19:14
@kylegach kylegach marked this pull request as ready for review March 26, 2024 19:14
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing this!! 🙏 Left a few minor suggestions

docs/writing-stories/index.md Outdated Show resolved Hide resolved
docs/writing-stories/index.md Outdated Show resolved Hide resolved
@shilman shilman added the ci:docs Run the CI jobs for documentation checks only. label Mar 26, 2024
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on, really appreciate it 🙏 ! I've left some items for you to look into when you have a moment so that we can get this in and published into the documentation.

docs/writing-stories/stories-for-multiple-components.md Outdated Show resolved Hide resolved
docs/writing-stories/stories-for-multiple-components.md Outdated Show resolved Hide resolved
docs/writing-stories/index.md Outdated Show resolved Hide resolved
docs/writing-stories/stories-for-multiple-components.md Outdated Show resolved Hide resolved
kylegach and others added 5 commits April 1, 2024 08:58
- Remove guidance to reuse entire stories
- Clarify other guidance
Co-authored-by: Michael Shilman <[email protected]>
Co-authored-by: jonniebigodes <[email protected]>
@kylegach kylegach force-pushed the update-docs-multiple-components branch from 2b1b883 to b8e46fe Compare April 1, 2024 14:59
@kylegach kylegach added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 2, 2024
@kylegach kylegach merged commit 6b773a6 into next Apr 2, 2024
23 checks passed
@kylegach kylegach deleted the update-docs-multiple-components branch April 2, 2024 15:21
storybook-bot pushed a commit that referenced this pull request Apr 2, 2024
…nents

Docs: Update multiple components guidance
(cherry picked from commit 6b773a6)
storybook-bot pushed a commit that referenced this pull request Apr 2, 2024
…nents

Docs: Update multiple components guidance
(cherry picked from commit 6b773a6)
storybook-bot pushed a commit that referenced this pull request Apr 3, 2024
…nents

Docs: Update multiple components guidance
(cherry picked from commit 6b773a6)
storybook-bot pushed a commit that referenced this pull request Apr 3, 2024
…nents

Docs: Update multiple components guidance
(cherry picked from commit 6b773a6)
storybook-bot pushed a commit that referenced this pull request Apr 3, 2024
…nents

Docs: Update multiple components guidance
(cherry picked from commit 6b773a6)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…nents

Docs: Update multiple components guidance
(cherry picked from commit 6b773a6)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…nents

Docs: Update multiple components guidance
(cherry picked from commit 6b773a6)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…nents

Docs: Update multiple components guidance
(cherry picked from commit 6b773a6)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…nents

Docs: Update multiple components guidance
(cherry picked from commit 6b773a6)
storybook-bot pushed a commit that referenced this pull request Apr 5, 2024
…nents

Docs: Update multiple components guidance
(cherry picked from commit 6b773a6)
storybook-bot pushed a commit that referenced this pull request Apr 5, 2024
…nents

Docs: Update multiple components guidance
(cherry picked from commit 6b773a6)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define pattern for story reuse in CSF3
3 participants