Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-Docgen: Make sure to be able to handle empty unions #26639

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Mar 25, 2024

Closes #26638

What I did

React docgen sometimes returns an empty union. It seems that somehow react-docgen knows it is a union, but didn't analyze the content of the union somehow.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@kasperpeulen kasperpeulen added bug ci:normal patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 25, 2024
Copy link

nx-cloud bot commented Mar 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3767f87. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen merged commit 889cfdf into next Mar 25, 2024
65 of 79 checks passed
@kasperpeulen kasperpeulen deleted the kasper/empty-union branch March 25, 2024 15:05
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
React-Docgen: Make sure to be able to handle empty unions
(cherry picked from commit 889cfdf)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
React-Docgen: Make sure to be able to handle empty unions
(cherry picked from commit 889cfdf)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
React-Docgen: Make sure to be able to handle empty unions
(cherry picked from commit 889cfdf)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
React-Docgen: Make sure to be able to handle empty unions
(cherry picked from commit 889cfdf)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
React-Docgen: Make sure to be able to handle empty unions
(cherry picked from commit 889cfdf)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
React-Docgen: Make sure to be able to handle empty unions
(cherry picked from commit 889cfdf)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
React-Docgen: Make sure to be able to handle empty unions
(cherry picked from commit 889cfdf)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
React-Docgen: Make sure to be able to handle empty unions
(cherry picked from commit 889cfdf)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
React-Docgen: Make sure to be able to handle empty unions
(cherry picked from commit 889cfdf)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
React-Docgen: Make sure to be able to handle empty unions
(cherry picked from commit 889cfdf)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
React-Docgen: Make sure to be able to handle empty unions
(cherry picked from commit 889cfdf)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot read properties of undefined (reading 'every') when using essentials addon with typescript
2 participants