Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix CLI always asking all automigrations #28238

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

ndelangen
Copy link
Member

What I did

I renamed a few variables so they are clearer in their intent.
I made isUpgrade it's own variable, separate from isOutdated which has a different meaning. (which I cleared up by renaming it).

Thanks for pairing with me on this @shilman

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen self-assigned this Jun 13, 2024
@ndelangen ndelangen added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch automigrations ci:normal labels Jun 13, 2024
@ndelangen ndelangen changed the title Make the CLI variable names be clearer, make isUpgrade it's own variable CLI: Fix CLI always asking all automigrations Jun 13, 2024
Copy link

nx-cloud bot commented Jun 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e06b7aa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@ndelangen ndelangen merged commit 6276e66 into next Jun 13, 2024
66 of 75 checks passed
@ndelangen ndelangen deleted the norbert/fix-automigrations-running-always branch June 13, 2024 13:55
@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 13, 2024
@valentinpalkovic valentinpalkovic added needs qa Indicates that this needs manual QA during the upcoming minor/major release and removed needs qa Indicates that this needs manual QA during the upcoming minor/major release labels Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants