Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: Detect Node version #28299

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Telemetry: Detect Node version #28299

merged 1 commit into from
Jun 24, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jun 20, 2024

Closes N/A

What I did

This PR adds a nodeVersion field to telemetry so we can cross reference issues to node versions

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added bug patch:yes Bugfix & documentation PR that need to be picked to main branch telemetry ci:normal labels Jun 20, 2024
@yannbf yannbf requested a review from shilman June 20, 2024 13:58
Copy link

nx-cloud bot commented Jun 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5d69b80. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic mentioned this pull request Jun 24, 2024
8 tasks
@yannbf yannbf merged commit aee10a9 into next Jun 24, 2024
53 of 55 checks passed
@yannbf yannbf deleted the yann/add-telemetry-info branch June 24, 2024 12:25
storybook-bot pushed a commit that referenced this pull request Jun 25, 2024
Telemetry: Detect Node version
(cherry picked from commit aee10a9)
@github-actions github-actions bot mentioned this pull request Jun 25, 2024
7 tasks
storybook-bot pushed a commit that referenced this pull request Jun 25, 2024
Telemetry: Detect Node version
(cherry picked from commit aee10a9)
storybook-bot pushed a commit that referenced this pull request Jun 26, 2024
Telemetry: Detect Node version
(cherry picked from commit aee10a9)
storybook-bot pushed a commit that referenced this pull request Jun 26, 2024
Telemetry: Detect Node version
(cherry picked from commit aee10a9)
storybook-bot pushed a commit that referenced this pull request Jun 26, 2024
Telemetry: Detect Node version
(cherry picked from commit aee10a9)
storybook-bot pushed a commit that referenced this pull request Jun 27, 2024
Telemetry: Detect Node version
(cherry picked from commit aee10a9)
storybook-bot pushed a commit that referenced this pull request Jun 27, 2024
Telemetry: Detect Node version
(cherry picked from commit aee10a9)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 27, 2024
@valentinpalkovic valentinpalkovic added the needs qa Indicates that this needs manual QA during the upcoming minor/major release label Jul 4, 2024
@ghengeveld ghengeveld removed the needs qa Indicates that this needs manual QA during the upcoming minor/major release label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants