Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Apply JavaScript-only story glob extensions for JavaScript projects #28338

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jun 25, 2024

Closes N/A

What I did

For new Storybook initializations, the Story glob file extension pattern will be limited to JavaScript-only files if we detect that the project is a JavaScript-only project.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Run a Javascript sandbox for template, e.g. yarn task --task sandbox --template cra/default-js --no-link
  2. Start Storybook

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic self-assigned this Jun 25, 2024
@valentinpalkovic valentinpalkovic added ci:daily Run the CI jobs that normally run in the daily job. bug labels Jun 25, 2024
@valentinpalkovic valentinpalkovic changed the title Use JS only story glob extension patterns in JavaScript projects Config: Apply JavaScript-only story glob extensions for JavaScript projects Jun 25, 2024
Copy link

nx-cloud bot commented Jun 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 74646c6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-story-glob-pattern branch 2 times, most recently from fde3d6f to 01c12fa Compare June 25, 2024 10:08
@valentinpalkovic valentinpalkovic marked this pull request as ready for review June 25, 2024 11:03
@@ -92,7 +92,7 @@ const publish = async (packages: { name: string; location: string }[], url: stri
const command = `cd ${path.resolve(
'../code',
location
)} && yarn pack --out=${PACKS_DIRECTORY}/${tarballFilename} && cd ${PACKS_DIRECTORY} && npm publish ./${tarballFilename} --registry ${url} --force --access restricted --ignore-scripts`;
)} && yarn pack --out=${PACKS_DIRECTORY}/${tarballFilename} && cd ${PACKS_DIRECTORY} && npm publish ./${tarballFilename} --registry ${url} --force --ignore-scripts`;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, it is impossible to build sandboxes locally in no-link mode. It seems, that non-scoped packages cannot be released in a restricted way

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into the same problem in the CPC branch, but I figured it was due to something I changed.

I resolved it the same way; there seems no reason to restrict access.

@valentinpalkovic valentinpalkovic merged commit 77c3c8a into next Jun 25, 2024
104 of 107 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-story-glob-pattern branch June 25, 2024 12:19
@mahikazversal
Copy link

@valentinpalkovic Is this PR by any chance related to the error which I am facing?
Cannot Find tsconfig.json in the directory when trying to configure Storybook in NX based workspace(which is having js based react-components). As shown in the image connected below:

image

@valentinpalkovic
Copy link
Contributor Author

No, I don't think it is related.

@mahikazversal
Copy link

mahikazversal commented Jul 1, 2024

@valentinpalkovic Can you guide a little about what measures could be taken?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants