Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Split the CLI, forward all commands except dev and build to @storybook/toolbox #28471

Closed
wants to merge 9 commits into from

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Jul 6, 2024

What I did

Implements the CLI split RFC:
#23590

  Install size Packages added Lock file increase
storybook@latest 130M 596 5560 lines
storybook@next 133M 470 4436 lines
CLI split 72M 117 1186 lines

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-28471-sha-3051a5b2. Try it out in a new sandbox by running npx [email protected] sandbox or in an existing project with npx [email protected] upgrade.

More information
Published version 0.0.0-pr-28471-sha-3051a5b2
Triggered by @kasperpeulen
Repository storybookjs/storybook
Branch kasper/storybook-toolbox
Commit 3051a5b2
Datetime Sat Jul 6 02:23:08 UTC 2024 (1720232588)
Workflow run 9815859530

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28471

@kasperpeulen kasperpeulen added maintenance User-facing maintenance tasks ci:normal labels Jul 6, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Updated code/core/src/common/versions.ts to include @storybook/toolbox version 8.2.0-beta.0
  • Modified code/core/src/core-server/utils/warnOnIncompatibleAddons.ts to import from @storybook/toolbox
  • Adjusted dependencies and scripts in code/lib/cli/package.json for new CLI structure
  • Forwarded most CLI commands to @storybook/toolbox in code/lib/cli/src/generate.ts
  • Added new files and configurations for @storybook/toolbox package in code/lib/toolbox directory

14 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @kasperpeulen. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/9815353874

Copy link

nx-cloud bot commented Jul 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3051a5b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @kasperpeulen. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/9815416602

@kasperpeulen kasperpeulen marked this pull request as draft July 6, 2024 01:28
@kasperpeulen kasperpeulen marked this pull request as ready for review July 6, 2024 02:12
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Renamed code/lib/cli/src/core-path.ts and code/lib/cli/src/index.ts to reflect CLI split.
  • Deleted code/lib/toolbox/core.cjs, core.d.ts, and core.js as part of CLI refactoring.
  • Updated import paths in scripts/create-nx-sandbox-projects.ts, scripts/event-log-checker.ts, and scripts/get-template.ts to use @storybook/toolbox.
  • Modified scripts/sandbox/generate.ts, scripts/sandbox/utils/template.ts, and scripts/task.ts to align with new CLI structure.
  • Adjusted scripts/utils/cli-step.ts to forward all commands except 'dev' and 'build' to @storybook/toolbox.

14 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@kasperpeulen kasperpeulen marked this pull request as draft July 6, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants