Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Fix support for TS < 4.7 #28887

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Test: Fix support for TS < 4.7 #28887

merged 1 commit into from
Aug 15, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Aug 15, 2024

Closes #28883

What I did

Fix the issue by changing how we expose the canvas proprty's type.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

As per recommendation from @kasperpeulen :

  • I went into a random story
  • Changed canvasElement to canvas
  • checked if there's autocompletion available (it was)

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.3 MB 76.3 MB 0 B 1 0%
initSize 169 MB 169 MB 24 B 2.44 0%
diffSize 92.6 MB 92.6 MB 24 B 2.44 0%
buildSize 7.46 MB 7.46 MB 0 B 2.34 0%
buildSbAddonsSize 1.61 MB 1.61 MB 0 B 2.56 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.3 MB 2.3 MB 0 B 2.27 0%
buildSbPreviewSize 350 kB 350 kB 0 B -2.38 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.46 MB 4.46 MB 0 B 2.27 0%
buildPreviewSize 3 MB 3 MB 0 B 2.38 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 26.3s 11.4s -14s -826ms -0.46 -129%
generateTime 22.4s 24s 1.6s 2.3 🔺6.8%
initTime 19.5s 21.2s 1.7s 1.56 🔺8.3%
buildTime 12.7s 11.3s -1s -392ms -0.55 -12.3%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.5s 8.8s 2.3s 0.8 26.9%
devManagerResponsive 4.3s 5.8s 1.5s 1.75 🔺26.2%
devManagerHeaderVisible 767ms 978ms 211ms 1.7 🔺21.6%
devManagerIndexVisible 810ms 1s 225ms 1.83 🔺21.7%
devStoryVisibleUncached 1.2s 1.5s 382ms 1.51 🔺24.1%
devStoryVisible 809ms 1s 227ms 1.69 🔺21.9%
devAutodocsVisible 642ms 890ms 248ms 1.32 🔺27.9%
devMDXVisible 650ms 865ms 215ms 0.94 24.9%
buildManagerHeaderVisible 650ms 815ms 165ms 0.7 20.2%
buildManagerIndexVisible 657ms 823ms 166ms 0.74 20.2%
buildStoryVisible 712ms 864ms 152ms 0.75 17.6%
buildAutodocsVisible 714ms 799ms 85ms 1.24 🔺10.6%
buildMDXVisible 586ms 730ms 144ms 0.93 19.7%

@ndelangen ndelangen changed the title apply fix for https://github.com/storybookjs/storybook/issues/28883 Test: Fix #28883 Aug 15, 2024
@ndelangen ndelangen self-assigned this Aug 15, 2024
@ndelangen ndelangen added bug patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Aug 15, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Aug 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 77e6044. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen merged commit 6245975 into next Aug 15, 2024
62 of 67 checks passed
@ndelangen ndelangen deleted the norbert/fix-28883 branch August 15, 2024 09:45
@shilman shilman changed the title Test: Fix #28883 Test: Fix support for TS < 4.7 Aug 16, 2024
@kasperpeulen kasperpeulen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: @storybook/test does not support typescript versions < 4.7
3 participants