Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Rename addon-vitest to addon-test #29014

Merged
merged 6 commits into from
Sep 2, 2024
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 30, 2024

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-29014-sha-a0ccf5b8. Try it out in a new sandbox by running npx [email protected] sandbox or in an existing project with npx [email protected] upgrade.

More information
Published version 0.0.0-pr-29014-sha-a0ccf5b8
Triggered by @valentinpalkovic
Repository storybookjs/storybook
Branch yann/rename-vitest-addon
Commit a0ccf5b8
Datetime Mon Sep 2 08:55:44 UTC 2024 (1725267344)
Workflow run 10664005211

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=29014

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.5 MB 76.5 MB 0 B 0.59 0%
initSize 161 MB 161 MB 1.55 kB -1.19 0%
diffSize 84.7 MB 84.7 MB 1.55 kB -1.31 0%
buildSize 7.48 MB 7.48 MB 357 B 0.88 0%
buildSbAddonsSize 1.62 MB 1.62 MB -21 B 0.36 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.31 MB 2.31 MB 0 B -0.5 0%
buildSbPreviewSize 352 kB 352 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.47 MB 4.47 MB -21 B 0.34 0%
buildPreviewSize 3 MB 3.01 MB 378 B 0.82 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 6.9s 6.4s -471ms -1.52 🔰-7.3%
generateTime 20.6s 19s -1s -607ms -0.7 -8.4%
initTime 17.8s 14.7s -3s -50ms -1.01 -20.6%
buildTime 10.9s 11.7s 766ms -0.47 6.5%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 7.1s 5.8s -1s -330ms -1.4 🔰-22.8%
devManagerResponsive 4.6s 3.8s -868ms -1.4 🔰-22.8%
devManagerHeaderVisible 808ms 648ms -160ms -1.3 🔰-24.7%
devManagerIndexVisible 856ms 687ms -169ms -1.3 🔰-24.6%
devStoryVisibleUncached 1.4s 1.1s -286ms -0.52 -23.9%
devStoryVisible 855ms 686ms -169ms -1.29 🔰-24.6%
devAutodocsVisible 798ms 672ms -126ms -0.46 -18.7%
devMDXVisible 680ms 586ms -94ms -1.09 -16%
buildManagerHeaderVisible 844ms 689ms -155ms -0.67 -22.5%
buildManagerIndexVisible 845ms 696ms -149ms -0.73 -21.4%
buildStoryVisible 885ms 728ms -157ms -0.82 -21.6%
buildAutodocsVisible 758ms 592ms -166ms -1.15 -28%
buildMDXVisible 735ms 581ms -154ms -1.33 🔰-26.5%

Greptile Summary

This PR renames the Storybook addon from 'vitest' to 'test', updating file names, import paths, and package references across multiple files.

  • Updated ADDON_ID in constants.ts still uses 'vitest', inconsistent with new addon name
  • README.md content still refers to 'Storybook Addon Vitest (Experimental)', needs updating
  • code/addons/test/package.json updated with new package name and export paths
  • Import paths in code/core/src/csf-tools/vitest-plugin/transformer.ts and other files updated to reflect new addon name
  • scripts/tasks/sandbox-parts.ts and scripts/tasks/sandbox.ts modified to use new addon name in dependency references

@yannbf yannbf added maintenance User-facing maintenance tasks ci:daily Run the CI jobs that normally run in the daily job. addon: test labels Aug 30, 2024
@yannbf yannbf changed the title Rename addon vitest to addon test Maintenance: Rename addon vitest to addon test Aug 30, 2024
Copy link

nx-cloud bot commented Aug 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9ca96c6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

29 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@shilman shilman changed the title Maintenance: Rename addon vitest to addon test Maintenance: Rename addon-vitest to addon-test Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: test ci:daily Run the CI jobs that normally run in the daily job. maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants