-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve linting #3011
Merged
Merged
Improve linting #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
added
maintenance
User-facing maintenance tasks
cleanup
Minor cleanup style change that won't show up in release changelog
accessibility
labels
Feb 17, 2018
igor-dv
approved these changes
Feb 18, 2018
@@ -90,7 +90,7 @@ | |||
// .add('with some emoji', () => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this file needed for ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like @danielduan forgot to remove it
This was referenced Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
cleanup
Minor cleanup style change that won't show up in release changelog
maintenance
User-facing maintenance tasks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
— Fixed existing lint warnings
— Switched
remark
to quite mode to remove all the "this file is OK" noise— Added
--report-unused-disable-directive
option tolint:js
script, so that we don't use more disablings than we actually need— Optimised eslint config: removed rules that duplicate airbnb config, fully ignored rules conflicting with Prettier
— Stopped ignoring accessibility rules and fixed all the violations
— Included
.storybook
and other previously ignored paths into lintingHow to test