Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve linting #3011

Merged
merged 12 commits into from
Feb 18, 2018
Merged

Improve linting #3011

merged 12 commits into from
Feb 18, 2018

Conversation

Hypnosphi
Copy link
Member

What I did

— Fixed existing lint warnings
— Switched remark to quite mode to remove all the "this file is OK" noise
— Added --report-unused-disable-directive option to lint:js script, so that we don't use more disablings than we actually need
— Optimised eslint config: removed rules that duplicate airbnb config, fully ignored rules conflicting with Prettier
— Stopped ignoring accessibility rules and fixed all the violations
— Included .storybook and other previously ignored paths into linting

How to test

$ yarn lint
yarn run v1.3.2
$ yarn lint:js . && yarn lint:ts **/*.ts && yarn lint:md .
$ cross-env NODE_ENV=production eslint --cache --cache-location=.cache/eslint --ext .js,.jsx,.json --report-unused-disable-directives .
$ tslint -p . -c tslint.json -t stylish '**/*.ts'
$ remark -q .
✨  Done in 10.34s.

@Hypnosphi Hypnosphi added maintenance User-facing maintenance tasks cleanup Minor cleanup style change that won't show up in release changelog accessibility labels Feb 17, 2018
@Hypnosphi Hypnosphi requested a review from a team February 17, 2018 21:27
@@ -90,7 +90,7 @@
// .add('with some emoji', () => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file needed for ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @danielduan forgot to remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility cleanup Minor cleanup style change that won't show up in release changelog maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants