Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add viewport addon to the Addon Gallery #3106

Conversation

mshaaban088
Copy link
Contributor

Issue: viewport addon is not shown as part of the Addon Gallery

What I did

  • I added it to the list with brief description (same as README file)

How to test

  • Just review the change for grammar mistakes or typos

Is this testable with jest or storyshots?

  • No

Does this need a new example in the kitchen sink apps?

  • No

Does this need an update to the documentation?

  • It is an update to the documentation, so no

If your answer is yes to any of these, please make sure to include it in your PR.

@mshaaban088 mshaaban088 force-pushed the feature/add-viewport-addon-to-addon-gallery branch from 4df35eb to bf21ea7 Compare February 27, 2018 01:08
@codecov
Copy link

codecov bot commented Feb 27, 2018

Codecov Report

Merging #3106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3106   +/-   ##
=======================================
  Coverage   36.08%   36.08%           
=======================================
  Files         438      438           
  Lines        9447     9447           
  Branches      881      893   +12     
=======================================
  Hits         3409     3409           
+ Misses       5497     5461   -36     
- Partials      541      577   +36
Impacted Files Coverage Δ
app/polymer/src/server/utils.js 0% <0%> (-100%) ⬇️
...tories_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
lib/components/src/table/cell.js 65.21% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
lib/core/src/client/manager/preview.js 0% <0%> (ø) ⬆️
addons/info/src/components/types/OneOf.js 61.11% <0%> (ø) ⬆️
addons/info/src/components/types/PrettyPropType.js 86% <0%> (ø) ⬆️
addons/viewport/src/components/RotateViewport.js 22.72% <0%> (ø) ⬆️
addons/storyshots/src/rn/loader.js 53.33% <0%> (ø) ⬆️
addons/info/src/components/types/Enum.js 0% <0%> (ø) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a2b26...43938a3. Read the comment docs.

@mshaaban088
Copy link
Contributor Author

mshaaban088 commented Feb 27, 2018

I updated the snapshots for both react_native and react_native_scripts, as they both were depending on prop-types ^15.6.0, and a new patch version of prop-types was released which broke the tests

Nothing really has changed in prop-types apart from, let me quote it, license header (see #164)

@Hypnosphi Hypnosphi merged commit c537cd6 into storybookjs:master Feb 27, 2018
@Hypnosphi Hypnosphi added maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch documentation and removed maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 6, 2018
Hypnosphi added a commit that referenced this pull request Mar 6, 2018
…to-addon-gallery

Add `viewport` addon to the Addon Gallery
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants