Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-freeze master #3149

Merged
merged 2 commits into from
Mar 13, 2018
Merged

Feature-freeze master #3149

merged 2 commits into from
Mar 13, 2018

Conversation

Hypnosphi
Copy link
Member

This blocks merging of PRs with BREAKING CHANGE and feature request PRs

@Hypnosphi Hypnosphi added maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 4, 2018
MAJOR: 'MAJOR',
};

const branchVersion = Versions.PATCH;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable should be configured per branch. Maybe this should be a field in package.json, I'm not sure

@Hypnosphi Hypnosphi requested a review from shilman March 4, 2018 23:31
@codecov
Copy link

codecov bot commented Mar 4, 2018

Codecov Report

Merging #3149 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3149   +/-   ##
=======================================
  Coverage   35.98%   35.98%           
=======================================
  Files         437      437           
  Lines        9476     9476           
  Branches      881      898   +17     
=======================================
  Hits         3410     3410           
- Misses       5490     5497    +7     
+ Partials      576      569    -7
Impacted Files Coverage Δ
app/vue/src/server/utils.js 0% <0%> (-100%) ⬇️
...-native/src/preview/components/OnDeviceUI/style.js 0% <0%> (ø) ⬆️
addons/knobs/src/angular/utils.js 82.14% <0%> (ø) ⬆️
...i/src/modules/ui/components/stories_panel/index.js 21.66% <0%> (ø) ⬆️
addons/a11y/src/components/WrapStory.js 61.11% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 51.85% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 48.64% <0%> (ø) ⬆️
addons/actions/src/lib/util/getPropertiesList.js 60% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 50% <0%> (ø) ⬆️
...ddons/actions/src/components/ActionLogger/index.js 0% <0%> (ø) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe4db9...0aec277. Read the comment docs.

Copy link
Member

@danielduan danielduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a good temporary thing for us to do.

@Hypnosphi Hypnosphi merged commit 1046c08 into master Mar 13, 2018
@Hypnosphi
Copy link
Member Author

temporary thing

Actually, for release branch it should be permanent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants