Persist background for @addon/background #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
reviewed
Apr 1, 2018
|
|
||
| this.channel.on('background-set', backgrounds => { | ||
| this.setState({ backgrounds }); | ||
| const currentBackground = api.getQueryParam('background'); | ||
| const currentBackground = api.getQueryParam('background') || this.state.currentBackground; |
There was a problem hiding this comment.
I'd prefer URL to be the single source of truth here. We already persist background changes in URL, let's just stop resetting that on story change:
https://github.com/wuweiweiwu/storybook/blob/12c5af9e513f989e03db87475811b86a4cdd718a/addons/background/src/BackgroundPanel.js#L91
Codecov Report
@@ Coverage Diff @@
## master #3331 +/- ##
==========================================
- Coverage 35.63% 35.62% -0.01%
==========================================
Files 472 472
Lines 10122 10121 -1
Branches 970 937 -33
==========================================
- Hits 3607 3606 -1
- Misses 5900 5918 +18
+ Partials 615 597 -18
Continue to review full report at Codecov.
|
|
@Hypnosphi Done! :) |
wuweiweiwu
changed the title
wuweiweiwu
changed the title
Hypnosphi
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2383
What I did
don't unset background url when changing stories.
How to test
Is this testable with Jest or Chromatic screenshots?
yes
Does this need a new example in the kitchen sink apps?
no
Does this need an update to the documentation?
no
If your answer is yes to any of these, please make sure to include it in your PR.