Fix render order in preview #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grimones
requested review from
alterx,
igor-dv,
kazupon,
leonrodenburg,
naipath,
ndelangen,
shilman and
thomasbertet
as code owners
Hypnosphi
approved these changes
May 2, 2018
Codecov Report
@@ Coverage Diff @@
## master #3520 +/- ##
=======================================
Coverage 37.61% 37.61%
=======================================
Files 459 459
Lines 10377 10377
Branches 929 929
=======================================
Hits 3903 3903
Misses 5934 5934
Partials 540 540
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: parent
clientWidthandclientHeightare equal to zero on page load (#3516).What I did
Changed the order of component rendering and showing main so components are not rendered in
<body>withdisplayset tonone.