-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Node.js 10 #3536
chore: add Node.js 10 #3536
Conversation
Generated by 🚫 dangerJS |
It seems there is an issue with the Netlify setup in the last few builds.
No commitlint style? So should I label it |
It seems no one applies this to the PRs / commits so where is the sense in this atm? Some commitlint / commitizen / husky solution should be probably used to enforce this (if |
Actually teamcity builds are running on |
Might have some unintended consequences. #3529 |
@wuweiweiwu testing in node 10 should not have any side-effects for users. If I understand @Hypnosphi correctly we are already testing on Node8 on CircleCI and Node10 on TeamCity. @DanielRuf You may commit with any message you like as long as it's decent. Our release process is mostly manual, but the commit process is beginner friendly. |
Sure, but what about Travis. Or what is the difference between running the tests on TeamCity and on Travis? We use CircleCI, TeamCity and Travis and for me it seems like CircleCI runs the same tasks which are also running on TeamCity. |
We run many test on both CircleCI and TeamCity. TeamCity runs some additional tests on examples.
Indeed, I've been meaning to get to that and fix it for the past few days, haven't gotten around to doing that. The TeamCity example tests are mostly a improved version so it hasn't made top priority on my list. |
What I did
Add Node.js for CI builds to test the current stable Node.js version.