Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report CLI tests to teamcity #4671

Merged
merged 3 commits into from
Nov 2, 2018
Merged

Report CLI tests to teamcity #4671

merged 3 commits into from
Nov 2, 2018

Conversation

Hypnosphi
Copy link
Member

Issue: master is red

What I did

Added teamcity service mesages to CLI tests which allows teamcity to recognise them as separate testcases. Then I muted the sfc_vue test to make build green and assigned investigation of the failure to @igor-dv

@Hypnosphi Hypnosphi added the maintenance User-facing maintenance tasks label Oct 31, 2018
@Hypnosphi Hypnosphi mentioned this pull request Oct 31, 2018
Closed
@codecov
Copy link

codecov bot commented Oct 31, 2018 •
edited
Loading

Codecov Report

Merging #4671 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4671   +/-   ##
=======================================
  Coverage   35.59%   35.59%           
=======================================
  Files         557      557           
  Lines        6732     6732           
  Branches      884      884           
=======================================
  Hits         2396     2396           
  Misses       3876     3876           
  Partials      460      460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b2b51...22c6c38. Read the comment docs.

shilman
shilman requested changes Nov 1, 2018
View reviewed changes
lib/cli/test/run_tests.sh Outdated Show resolved Hide resolved
shilman
shilman approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit edcff0e into master Nov 2, 2018
@shilman shilman deleted the cli-teamcity-report branch November 2, 2018 20:12
@igor-dv
Copy link
Member

igor-dv commented Nov 3, 2018

Looks like tests are failing now in master (the Tests) https://teamcity.jetbrains.com/viewType.html?buildTypeId=OpenSourceProjects_Storybook_Test&branch_OpenSourceProjects_Storybook=%3Cdefault%3E&tab=buildTypeStatusDiv

@Hypnosphi
Copy link
Member Author

Weird, yarn test --core --teamcity works OK locally

@Hypnosphi
Copy link
Member Author

Seems like node 11 is the reason. I'll enforce node 10

@Hypnosphi
Copy link
Member Author

#4720

This was referenced Dec 1, 2018
Closed
Closed
Closed
Open
Closed
Open
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv igor-dv is a code owner

@ndelangen ndelangen Awaiting requested review from ndelangen ndelangen is a code owner

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal stijnkoopal is a code owner

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hypnosphi @igor-dv @shilman