HTML: support knobs for both cached and uncached nodes #6783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
added
bug
patch:yes
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-html-no-umnount-same-node-story.storybook.now.sh |
shilman
approved these changes
May 16, 2019
ndelangen
approved these changes
May 18, 2019
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6190 undid #4822
What I did
Used reference comparison to fix #5017 and #6623 while keeping the effect of #4822
How to test
– Open Knobs/DOM story, check that the knob still works
– Open Knobs/CSS transitions story, observe transitions when changing color