-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unresponsive textarea from addon-event #6938
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-lonyele-fix-addon-event-textarea.storybook.now.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
@lonyele I invited you to the github org. 👍 |
@shilman just ping for the comment. I'd like to migrate addon-event to typescript... |
@ndelangen hm.. same goes here. Color is changed but it is not expected. I'll investigate this too |
Issue: Fixes #6936
What I did
Problem
From
getDerivedStateFromProps
, comparing some props and some state(alwaysundefined
) always initializes state which makes changing on textarea unresponsive.Implementation
isEqual
to properly compare changing props' payload and state's prevPayloadHow to test
If your answer is yes to any of these, please make sure to include it in your PR.