-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7161 Fix error raw loader module not found in angular 8 #7207
7161 Fix error raw loader module not found in angular 8 #7207
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-baraalex-7161-raw-loader-module-not-found.storybook.now.sh |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, the docs describe to use loader like that and all tests have passed.
LGTM
I'm not sure why this
- has worked before
- does fix the original issue. I could create an ng8 app without having trouble with raw-loader
@baraalex could you explain this if possible, please?
@shilman any doubts merging this?
@kroeder I don't really understand the change. @ndelangen can you take a look? |
will enforce to resolve the
will have let webpack figure it out, I think that might resolve it from where the file is required. In either case, at least one
Do you mean a build of the angular app or building a static version of storybook for angular? |
I don't know why but I have an app on angular and when I updated it to angular 8, with the angular client, it stopped to work and it was because raw-loader couldn't be found.
Both building a static version and running storybook live version were failing because of this problem. |
Issue: #7161
What I did
Fix error webpack not finding
raw-loader
on angular build.Webpack documentation on how to use webpack loaders