Angular: Convert angular-cli stories to CSF #7668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/9ne7rj16p |
shilman
added
maintenance
kroeder
reviewed
Aug 4, 2019
| }, | ||
| }); | ||
|
|
||
| actionOnly.story = { |
There was a problem hiding this comment.
Is there a way to type this? In strict: true you most likely have to
export const actionOnly: any in order to call .story
Maybe actionOnly: Story = () => { ... }?
|
@igor-dv angularshots seems to be failing on this PR and i can repro on my dev machine. any chance you can take a look for me? i think it's angular-specific since |
|
Self-merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7101
What I did
Ran
sb migrate storieof-to-csfand minor touchupHow to test