Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@storybook/addon-cssresources - Hide Code #9627

Merged
merged 4 commits into from
Jan 29, 2020
Merged

Conversation

Oreoz
Copy link

@Oreoz Oreoz commented Jan 24, 2020

Issue:

As a user, I want to hide the style of certain CSS Resources as they are quite long and makes switching between them cumbersome.

What I did

Enable the consumer to hide the CSS Resources' code through the hideCode property.

How to test

  • Is this testable with Jest or Chromatic screenshots? Should be
  • Does this need a new example in the kitchen sink apps? Don't think so
  • Does this need an update to the documentation? Perhaps

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Jan 24, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

@Oreoz Oreoz changed the title @storybook/addon-cssresources - Hide css code @storybook/addon-cssresources - Hide Code Jan 24, 2020
@Oreoz
Copy link
Author

Oreoz commented Jan 24, 2020

Not quite sure how I can fix the failing Danger JS check as it looks like an integration error.

@ndelangen
Copy link
Member

It should be all good and merge-able now @Oreoz

Great job on this PR!

@ndelangen ndelangen self-assigned this Jan 28, 2020
@ndelangen ndelangen added this to the 6.0.0 milestone Jan 28, 2020
@Oreoz
Copy link
Author

Oreoz commented Jan 29, 2020

@ndelangen Cool! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants