-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating deps to handle TS 4.9 #237
Updating deps to handle TS 4.9 #237
Conversation
Codecov ReportBase: 75.86% // Head: 75.86% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## next #237 +/- ##
=======================================
Coverage 75.86% 75.86%
=======================================
Files 11 11
Lines 174 174
Branches 36 36
=======================================
Hits 132 132
Misses 42 42
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
package.json
Outdated
"wait-on": "^6.0.0" | ||
"typescript": "~4.9.4", | ||
"wait-on": "^6.0.0", | ||
"webpack": "^5.75.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding webpack
as a dependency here, is that on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I thought I got some peer dep warnings, but I think I might be mistaken, will try without.
package.json
Outdated
"@storybook/core-common": "next", | ||
"@storybook/csf": "next", | ||
"@storybook/csf-tools": "next", | ||
"@storybook/store": "next", | ||
"@storybook/preview-api": "next", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this should be done in this PR. It will be breaking for any user with sb < alpha 52, and some people can't upgrade as they're blocked on storystorev6 issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, okay, I got some deprecation warnings in my console, about using @storybook/store
, but I will revert then.
🚀 PR was released in |
Fixes #235
📦 Published PR as canary version:
0.9.3--canary.237.9eb3c32.0
✨ Test out this PR locally via:
Version
Published prerelease version:
v0.10.0-next.4
Changelog
🚀 Enhancement
🐛 Bug Fix
📝 Documentation
Authors: 4