Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating deps to handle TS 4.9 #237

Merged

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Dec 28, 2022

Fixes #235

📦 Published PR as canary version: 0.9.3--canary.237.9eb3c32.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

Version

Published prerelease version: v0.10.0-next.4

Changelog

🚀 Enhancement

🐛 Bug Fix

📝 Documentation

Authors: 4

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022

Codecov Report

Base: 75.86% // Head: 75.86% // No change to project coverage 👍

Coverage data is based on head (9eb3c32) compared to base (16bcf70).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #237   +/-   ##
=======================================
  Coverage   75.86%   75.86%           
=======================================
  Files          11       11           
  Lines         174      174           
  Branches       36       36           
=======================================
  Hits          132      132           
  Misses         42       42           
Impacted Files Coverage Δ
src/util/getStorybookMain.ts 85.71% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

package.json Outdated
"wait-on": "^6.0.0"
"typescript": "~4.9.4",
"wait-on": "^6.0.0",
"webpack": "^5.75.0"
Copy link
Contributor

@JReinhold JReinhold Dec 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding webpack as a dependency here, is that on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I thought I got some peer dep warnings, but I think I might be mistaken, will try without.

package.json Outdated
"@storybook/core-common": "next",
"@storybook/csf": "next",
"@storybook/csf-tools": "next",
"@storybook/store": "next",
"@storybook/preview-api": "next",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should be done in this PR. It will be breaking for any user with sb < alpha 52, and some people can't upgrade as they're blocked on storystorev6 issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay, I got some deprecation warnings in my console, about using @storybook/store, but I will revert then.

@kasperpeulen kasperpeulen added bug Something isn't working patch Increment the patch version when merged labels Dec 28, 2022
@kasperpeulen kasperpeulen merged commit 725761b into next Dec 28, 2022
@kasperpeulen kasperpeulen deleted the kasper/sb-1133-test-runner235-bug-nometa-error-with branch December 28, 2022 14:02
This was referenced Mar 31, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

🚀 PR was released in v0.10.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] "NoMeta error" with Storybook v7 with typescript satisfies
4 participants