Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dedupe dependency versions in yarn.lock #347

Merged
merged 1 commit into from
Sep 6, 2023
Merged

chore: dedupe dependency versions in yarn.lock #347

merged 1 commit into from
Sep 6, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 3, 2023 •
edited
Loading

This commits the result of running yarn dedupe (docs).

node_modules size before vs after:

Before:

$ du -hs node_modules
1.1G    node_modules

After:

$ du -hs node_modules
577M    node_modules

@legobeat legobeat changed the title chore: dedupe depenency versions in yarn.lock chore: dedupe dependency versions in yarn.lock Sep 3, 2023
@socket-security
Copy link

socket-security bot commented Sep 3, 2023 •
edited
Loading

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@babel/core 7.21.4...7.22.9 None +0/-4 769 kB nicolo-ribaudo
@babel/preset-env 7.21.4...7.22.9 None +0/-62 143 kB nicolo-ribaudo

🚮 Removed packages: @storybook/[email protected]

@legobeat legobeat mentioned this pull request Sep 3, 2023
Merged
@legobeat legobeat marked this pull request as ready for review September 3, 2023 00:48
kasperpeulen
kasperpeulen approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasperpeulen kasperpeulen added skip-release Preserve the current version when merged internal Changes only affect the internal API labels Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9e1136e) 76.66% compared to head (4294f27) 76.66%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next     #347   +/-   ##
=======================================
  Coverage   76.66%   76.66%           
=======================================
  Files          11       11           
  Lines         180      180           
  Branches       40       40           
=======================================
  Hits          138      138           
  Misses         42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yannbf yannbf merged commit 6773bdf into storybookjs:next Sep 6, 2023
11 checks passed
@github-actions github-actions bot mentioned this pull request Oct 5, 2023
Merged
@legobeat legobeat deleted the yarn-dedupe-202309 branch October 7, 2023 03:14
@github-actions github-actions bot mentioned this pull request Oct 8, 2023
Merged
This was referenced Oct 24, 2023
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

🚀 PR was released in v0.14.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

@yannbf yannbf Awaiting requested review from yannbf yannbf is a code owner

Assignees
No one assigned
Labels
internal Changes only affect the internal API released skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @kasperpeulen @yannbf