Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Browser has been closed" crash on uncaught page errors #397

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 20, 2023

Closes #336

This PR introduces changes to fix a critical bug and handle uncaught page errors, which previously would crash the browser, but now will be provided as proper errors in the specific story which causes it.

Version

Published prerelease version: v0.15.2-next.2

Changelog

🐛 Bug Fix

  • Fix "Browser has been closed" crash on uncaught page errors #397 (@yannbf)
  • Clarify difference between skipped and excluded tags #396 (@IanVS @yannbf)
  • Refactor: Rename "render" hooks to "visit" hooks #394 (@yannbf)
  • Docs: Update tags documentation #393 (@yannbf)

Authors: 2

@yannbf yannbf added the patch Increment the patch version when merged label Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6dc95f) 80.64% compared to head (2d2bbcc) 80.64%.
Report is 3 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #397   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files          12       12           
  Lines         217      217           
  Branches       56       56           
=======================================
  Hits          175      175           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yannbf yannbf changed the title Fix crash on uncaught page errors Fix "Browser has been closed" crash on uncaught page errors Nov 20, 2023
@yannbf yannbf merged commit 64c9b3b into next Nov 20, 2023
13 of 15 checks passed
@yannbf yannbf deleted the fix/browser-crash-on-uncaught-error branch November 20, 2023 14:33
@yannbf yannbf mentioned this pull request Nov 21, 2023
Copy link

🚀 PR was released in v0.15.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error output if a test fail says "page.evaluate: Browser has been closed"
1 participant