Fix Windows support in coverage generation #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
force-pushed
the
yann/fix-coverage-process
branch
from
862a65b
to
8fa90ff
Compare
yannbf
force-pushed
the
yann/fix-coverage-process
branch
from
8fa90ff
to
2324514
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #459
What I did
This PR attempts to fix a Windows compatibility issue when generating coverage. By using node to execute the binary file instead, it should work cross-platform.
Checklist for Contributors
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
Checklist for Maintainers
Make sure this PR contains one of the labels below:
Available labels
skip-release: Skip any releases, e.g., documentation only changes, CI config etc.patch: Upgrade patch version (e.g. 0.0.x)minor: Upgrade patch version (e.g. 0.x.0)major: Upgrade patch version (e.g. x.0.0)📦 Published PR as canary version:
0.18.1--canary.461.2324514.0✨ Test out this PR locally via: