Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-runner file for hook configuration #53

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Test-runner file for hook configuration #53

merged 3 commits into from
Feb 16, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 16, 2022 •
edited by github-actions bot
Loading

What I did

  • Added a new test-runner config file & types
  • Updated the documentation

Tried to remove the old API but couldn't get it working so I went back to the old way.

📦 Published PR as canary version: 0.0.3-canary.53.755f06f.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

Version

Published prerelease version: v0.0.3-next.3

Changelog

🐛 Bug Fix

  • Test-runner file for hook configuration #53 (@shilman)
  • feat: add update snapshot command to cli #52 (@yannbf)
  • fix: improve error message in start-storybook #51 (@yannbf)
  • Respect stories defined in main.js #46 (@yannbf)

Authors: 2

@shilman shilman added the feature request New feature or request label Feb 16, 2022
@shilman shilman requested a review from yannbf February 16, 2022 08:28
yannbf
yannbf approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! I added a few small comments

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
playwright/jest-setup.js Show resolved Hide resolved
@yannbf yannbf added the patch Increment the patch version when merged label Feb 16, 2022
@yannbf yannbf merged commit 2980d2b into next Feb 16, 2022
This was referenced Feb 16, 2022
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this pull request Feb 23, 2022
Merged
@yannbf yannbf mentioned this pull request Feb 23, 2022
Merged
@shilman shilman mentioned this pull request Mar 2, 2022
Closed
@yannbf yannbf deleted the feat/non-eject-customization branch August 23, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees
No one assigned
Labels
feature request New feature or request patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @yannbf