Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store: always call composeConfigs in setProjectAnnotations #18916

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 11, 2022

Issue: N/A

What I did

The testing utilities were only calling composeConfigs in case the project annotations providade were an array, which is wrong given that composeConfigs provides sensible defaults which are necessary in prepareStory.

This is needed for #18673 to work correctly with the testing utilities

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added bug patch:yes Bugfix & documentation PR that need to be picked to main branch core labels Aug 11, 2022
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yannbf yannbf merged commit 30df6a2 into next Aug 11, 2022
@yannbf yannbf deleted the fix/set-project-annotations branch August 11, 2022 13:38
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Aug 17, 2022
shilman pushed a commit that referenced this pull request Aug 17, 2022
Store: always call composeConfigs in setProjectAnnotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants