CI: Fix test-runner build step #19255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
shilman
changed the title
tmeasday
reviewed
Oct 6, 2022
|
@tmeasday @IanVS @yannbf this PR upgrades the test runner so that it actually tests (earlier versions were swallowing 7.0 errors). However, CI is currently breaking with "Cannot call renderSelection before initialization" in Vite projects, which was fixed here #19071. Any idea why it might be failing in the test runner? |
tmeasday
approved these changes
Oct 9, 2022
🤔 hmmm, that issue is due to timing related stuff so I guess it could just be a new kind of timing triggering a similar kind of issue. Not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
Chromatic was failing on play function errors and test-runner was swallowing them because of a bug in the test-runner storybookjs/test-runner#195
What I did
Upgrade test-runner
How to test