Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(angular): drop support for angular < 13 #19368

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

kroeder
Copy link
Member

@kroeder kroeder commented Oct 5, 2022

What I did

According to the Angular LTS plan, Angular 12
support ends in Nov 2022. A lot of code exists
to support Angular < 13 which increases the
maintenance effort and decreases the
contribution DX of framework/angular.

This PR removes all code related to Angular < 13 in preparation for Storybook 7.0

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@kroeder kroeder added maintenance User-facing maintenance tasks angular BREAKING CHANGE labels Oct 5, 2022
@kroeder kroeder requested review from ThibaudAV and ndelangen and removed request for ThibaudAV October 5, 2022 20:47
@kroeder kroeder removed the maintenance User-facing maintenance tasks label Oct 5, 2022
According to the Angular LTS plan, Angular 12
support ends in Nov 2022. A lot of code exists
to support Angular < 13 which increases the
maintenance effort and decreases the
contribution DX of framework/angular.

BREAKING CHANGE: Dropped support for Angular 12
@kroeder kroeder force-pushed the angular/remove-angular-12-support branch from c16bb70 to 17bd921 Compare October 5, 2022 20:56
@kroeder kroeder changed the title Draft: refactor(angular): drop support for angular < 13 refactor(angular): drop support for angular < 13 Oct 5, 2022
@kroeder
Copy link
Member Author

kroeder commented Oct 5, 2022

Example app is running perfectly fine and I think I found every code related to Angular < 13
There are a few more places tagged with "drop before storybook 7.0 release" but they are not related to the support of Angular < 13

@ThibaudAV any second thoughts? @ndelangen already agreed to this

This is the first PR of a smaller series with the goal to improve the DX for framework/angular in the repo. This also massively decreases the mental load and maintenance effort in the code base

@ndelangen ndelangen added maintenance User-facing maintenance tasks and removed BREAKING CHANGE labels Oct 5, 2022
@ndelangen
Copy link
Member

I think a migration note in MIGRATION.md is warranted about this @kroeder 👍

@ThibaudAV
Copy link
Contributor

🚀
Only thing to add is :
What about now always support only same supported version than Angular ? 😁
https://angular.io/guide/releases

Is more easy for many reason and try to support the last one as fast as possible

@kroeder
Copy link
Member Author

kroeder commented Oct 6, 2022

🚀
Only thing to add is :
What about now always support only same supported version than Angular ? 😁
https://angular.io/guide/releases

Is more easy for many reason and try to support the last one as fast as possible

Since dropping support is a breaking change, storybook can only do this between major releases. Angular has 2 majors a year and supports the last 3, storybook has about 1 a year, right? So, most likely storybook would need support the last 4

But officially, I totally agree with you! We should only support all lts versions

@ndelangen @shilman I don't know with whom I already have discussed this on discord but anyway, should we do this? Only support angular lts? (basically 1 1/2 year of angular code)

If yes, where should we document this?

@kroeder
Copy link
Member Author

kroeder commented Oct 6, 2022

I think a migration note in MIGRATION.md is warranted about this @kroeder 👍

@ndelangen I added a note to the MIGRATION.md - is this good enough?

@ndelangen ndelangen merged commit ee51172 into next Oct 6, 2022
@ndelangen ndelangen deleted the angular/remove-angular-12-support branch October 6, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants