Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Replace degit with giget #19870

Merged
merged 1 commit into from
Nov 19, 2022
Merged

CLI: Replace degit with giget #19870

merged 1 commit into from
Nov 19, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 17, 2022

Issue: N/A

What I did

degit has been unmaintained for quite some time, and there are sporadic issues which will never get resolved, such as:

ZlibError: zlib: unexpected end of file

A good successor is giget, and this PR replaces every usage of degit with giget.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added maintenance User-facing maintenance tasks cli labels Nov 17, 2022
@socket-security
Copy link

socket-security bot commented Nov 17, 2022

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@yannbf yannbf force-pushed the fix/replace-degit-with-gegit branch 2 times, most recently from fe4d1f7 to 909ea5b Compare November 18, 2022 14:00
- degit is unmaintained, gegit is a good successor
@yannbf yannbf force-pushed the fix/replace-degit-with-gegit branch from 909ea5b to a9a5524 Compare November 18, 2022 16:12
@shilman shilman changed the title replace degit with giget CLI: Replace degit with giget Nov 19, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this @yannbf 🙏

@shilman shilman merged commit d49761b into next Nov 19, 2022
@shilman shilman deleted the fix/replace-degit-with-gegit branch November 19, 2022 10:04
@yannbf yannbf added the linear label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants