This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Dispute and licensing integration #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramarti
force-pushed
the
integration_licensing_disputes
branch
from
6b48854
to
9f11574
Compare
Ramarti
commented
Feb 15, 2024
LeoHChen
reviewed
Feb 16, 2024
LeoHChen
reviewed
Feb 16, 2024
…etter for LicenseRegistry
… of revoked IPA licenses
LeoHChen
force-pushed
the
integration_licensing_disputes
branch
from
83550a1
to
2d69669
Compare
LeoHChen
reviewed
Feb 16, 2024
LeoHChen
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
LGTM overall, many todo items, need to revisit post-beta.
In the documentation, we have to make it clear about the current limitation of the dispute and tag module. @Spablob
Also, please try not to combine changes all in one PR.
Spablob
reviewed
Feb 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR integrates the states of the Dispute Module into the Licensing pipeline.
Note that a dispute tag gets attached only if a judge decides on the request for arbitration. Anyone can initiate an arbitration, which costs money, against an IP asset. The arbitration initiator can "settle" the dispute, which removes the tag from the IP asset.
Misc.
The license NFT metadata has been updated to include more information, including the revoked status.